Colours, border and thumbnail size come from ~/.config/wl-pick/config
now, since ten more flags would have made a keybinding unreadable — the
split the rofi setup this replaces already used: look in a file,
behaviour on the command line. Flat `key = value` lines, so no TOML
dependency for something with nothing to nest, and a flag still beats the
file.
Sizes take sway's units. `600px` is absolute; `70ppt` is a percentage of
the display the grid appears on, resolved on every run rather than baked
in, so one config suits monitors of different sizes. That needed the
overlay to know which display it is on, so it now asks sway for the
focused one and maps there explicitly, at that display's scale, instead
of letting the compositor choose and taking the largest scale in use —
which was wrong on any mixed-DPI setup.
tile-width and tile-height are maxima. Given only a width, the height
follows the display's aspect: a 16:9 cell, inherited from a rofi theme
written for a landscape screen, wasted about half of every cell on a
portrait monitor. And if the grid would outgrow the display, tiles now
shrink together, keeping their shape, so thirty windows produce small
tiles rather than a surface larger than the screen. The surface is capped
at the display as a backstop, because on a small screen the padding and
label rows can exceed it no matter how small the tiles get.
Two bugs the tests caught while writing this:
- Stripping comments at the first '#' ate colour values, so
`selection = #d79921 # note` parsed as empty. A comment is now a '#'
followed by whitespace or end of line; a colour is '#' then a hex
digit, so the two cannot collide.
- Twelve tiles at the old fixed size fit a 1280x800 screen, so the first
version of the shrink test proved nothing. It now uses numbers that
genuinely overflow.
Also: failing to reach sway said only "No such file or directory", which
tells a first-time user nothing; it now names sway and what it wanted.
main.rs had grown to 1290 lines holding everything: the CLI, the client
state, the capture engine, the drawing, the input handling and twelve
Dispatch impls. It is now orchestration only, and the concerns live where
you would look for them — cli, app, capture, overlay — with the module
docs saying what each owns. No behaviour changed; the code moved.
Iterating in response to review left residue, now gone:
- Tile::handle was only ever written. Dropping a wayland-rs proxy does
not destroy the object, so nothing needed it held.
- Tile::failed likewise: an earlier captures_settled() read it, and
`settled` is what everything waits on now.
- A blanket #[allow(dead_code)] on Tile hid both of those. Fields are
pub(crate) rather than pub so the lint keeps working.
- Tile's doc comment had drifted onto the Format enum during a patch.
- Three consecutive `if args.verbose` blocks became describe() and
report(), and the loose ticks/releases/starved/pool_bytes counters
became one Stats. `releases` went: frames already imply it.
- quit + quit_why + activate became one Ending enum and picked, so
"closed by the compositor" is a state rather than a string.
- App::new took seven positional arguments, two of them bare integers in
a row; the four that always travel together are now Settings.
- sway::scale and the display listing each called get_outputs; one call
does both.
- scaled(rect, n) became Rect::scaled(n), and Format lives with Target
where render() dispatches on it.
README had drifted too: the usage line still advertised --print, which
no longer exists, and omitted --format and --no-outputs. Its flag list is
now checked against --help, the memory figures are re-measured, and there
is a source layout for anyone arriving cold.
Milad Alizadeh